From 92edc11e97bcf031d2aeb67e7186794b97466b94 Mon Sep 17 00:00:00 2001
From: Emmanuel Raviart <emmanuel@raviart.com>
Date: Tue, 22 Nov 2022 10:26:06 +0100
Subject: [PATCH] Lint ReformChanges component
---
src/lib/components/ReformsChanges.svelte | 53 ++++++++++++------------
1 file changed, 27 insertions(+), 26 deletions(-)
diff --git a/src/lib/components/ReformsChanges.svelte b/src/lib/components/ReformsChanges.svelte
index e646bfadf..ad5b3d7a7 100644
--- a/src/lib/components/ReformsChanges.svelte
+++ b/src/lib/components/ReformsChanges.svelte
@@ -8,11 +8,11 @@
getParameter,
rootParameter,
} from "$lib/parameters"
- import type { ParametricReform } from "$lib/reforms"
import {
ParameterReformChangeType,
reformChangesByName,
- reformMetadataByName,
+ // reformMetadataByName,
+ type ParametricReform,
} from "$lib/reforms"
import { newSimulationUrl } from "$lib/urls"
import { formatValue } from "$lib/values"
@@ -25,29 +25,30 @@
const billName = getContext("billName") as Writable<string | undefined>
- $: billChanges = reformChangesByName[$billName]
+ $: billChanges =
+ $billName === undefined ? undefined : reformChangesByName[$billName]
- function* walkParametersChangeName(parameterChange, ids: string[] = []) {
- if (Object.keys(parameterChange).length === 1) {
- for (const [parameterId, childChange] of Object.entries(
- parameterChange,
- )) {
- if (
- (childChange as { children: { [key: string]: unknown } }).children ===
- undefined
- ) {
- yield [...ids, parameterId].join(".")
- } else {
- yield* walkParametersChangeName(
- (childChange as { children: { [key: string]: unknown } }).children,
- [...ids, parameterId],
- )
- }
- }
- } else {
- yield ids.join(".")
- }
- }
+ // function* walkParametersChangeName(parameterChange, ids: string[] = []) {
+ // if (Object.keys(parameterChange).length === 1) {
+ // for (const [parameterId, childChange] of Object.entries(
+ // parameterChange,
+ // )) {
+ // if (
+ // (childChange as { children: { [key: string]: unknown } }).children ===
+ // undefined
+ // ) {
+ // yield [...ids, parameterId].join(".")
+ // } else {
+ // yield* walkParametersChangeName(
+ // (childChange as { children: { [key: string]: unknown } }).children,
+ // [...ids, parameterId],
+ // )
+ // }
+ // }
+ // } else {
+ // yield ids.join(".")
+ // }
+ // }
</script>
<!--{#if $billName !== undefined}-->
@@ -185,7 +186,7 @@
...displayMode,
parameterName,
parametersVariableName: undefined,
- })}>{parameter.titles.filter(Boolean).join(" > ")} =</a
+ })}>{parameter?.titles?.filter(Boolean).join(" > ")} =</a
>
<br />
{#if parameterReform.type === ParameterReformChangeType.Scale}
@@ -194,7 +195,7 @@
<span class="bg-le-jaune text-right font-bold"
>{formatValue(
parameterReform.value,
- asValueParameter(parameter).unit,
+ asValueParameter(parameter)?.unit,
)}</span
>
{/if}
--
GitLab