From 9c048408c5aebe2a282038b1601c4069c59315e8 Mon Sep 17 00:00:00 2001
From: David Smadja <david.smadja@assemblee-nationale.fr>
Date: Mon, 24 Mar 2025 16:54:07 +0100
Subject: [PATCH 1/3] Add aria-label
---
.../test_case_selected/graph/TestCaseGraph.svelte | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lib/components/impacts_view/test_cases_view/test_case_selected/graph/TestCaseGraph.svelte b/src/lib/components/impacts_view/test_cases_view/test_case_selected/graph/TestCaseGraph.svelte
index ed7802dc6..566a86399 100644
--- a/src/lib/components/impacts_view/test_cases_view/test_case_selected/graph/TestCaseGraph.svelte
+++ b/src/lib/components/impacts_view/test_cases_view/test_case_selected/graph/TestCaseGraph.svelte
@@ -1061,6 +1061,7 @@
initialPlacement="top"
>
<button
+ aria-labelledby="hide-show-tooltip-{variable.name}"
class="group h-full pl-0.5 pr-1"
onclick={() => {
variableCustomizations[
@@ -1095,7 +1096,7 @@
</button>
{#snippet tooltip()}
<div
- id="hide-show-tooltip"
+ id="hide-show-tooltip-{variable.name}"
class="overflow-hidden rounded-lg bg-black px-2 py-1 text-sm text-white"
title={isSelected ? "Cacher" : "Montrer"}
>
--
GitLab
From 6fbce49bcf48da0342fd5fa136876decf5b7ab67 Mon Sep 17 00:00:00 2001
From: David Smadja <david.smadja@assemblee-nationale.fr>
Date: Mon, 24 Mar 2025 16:57:34 +0100
Subject: [PATCH 2/3] Add aria-label
---
.../test_case_selected/graph/TestCaseGraph.svelte | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/lib/components/impacts_view/test_cases_view/test_case_selected/graph/TestCaseGraph.svelte b/src/lib/components/impacts_view/test_cases_view/test_case_selected/graph/TestCaseGraph.svelte
index 566a86399..2642d8bce 100644
--- a/src/lib/components/impacts_view/test_cases_view/test_case_selected/graph/TestCaseGraph.svelte
+++ b/src/lib/components/impacts_view/test_cases_view/test_case_selected/graph/TestCaseGraph.svelte
@@ -1006,6 +1006,7 @@
>
{#each getCustomizations(groupName, row.calculationName) as customization}
<button
+ aria-label="personnaliser l'apparence"
class="h-10 w-10 rounded border-2 border-neutral-300 hover:border-blue-500"
onclick={() => {
variableCustomizations[
@@ -1071,6 +1072,7 @@
)
].selected = isSelected ? "false" : "true"
updateVariableValuesAndCustomizations()
+ console.log({ variableCustomizations })
}}
>
<div
--
GitLab
From d5309a6575ba7b52334611c5a36ea46bd0563ef0 Mon Sep 17 00:00:00 2001
From: David Smadja <david.smadja@assemblee-nationale.fr>
Date: Tue, 25 Mar 2025 11:32:10 +0100
Subject: [PATCH 3/3] Fix hideshow intertwinning for some variables
---
.../test_case_selected/graph/TestCaseGraph.svelte | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/lib/components/impacts_view/test_cases_view/test_case_selected/graph/TestCaseGraph.svelte b/src/lib/components/impacts_view/test_cases_view/test_case_selected/graph/TestCaseGraph.svelte
index 2642d8bce..3592bdb95 100644
--- a/src/lib/components/impacts_view/test_cases_view/test_case_selected/graph/TestCaseGraph.svelte
+++ b/src/lib/components/impacts_view/test_cases_view/test_case_selected/graph/TestCaseGraph.svelte
@@ -752,7 +752,7 @@
variableCustomizations[key] =
variableCustomizations[
getVariableCustomizationName(
- variable.parent,
+ variable.name,
row.calculationName,
)
] ??
@@ -843,7 +843,7 @@
variableCustomizations[key] =
variableCustomizations[
getVariableCustomizationName(
- variable.parent,
+ variable.name,
row.calculationName,
)
] ??
@@ -1072,7 +1072,6 @@
)
].selected = isSelected ? "false" : "true"
updateVariableValuesAndCustomizations()
- console.log({ variableCustomizations })
}}
>
<div
--
GitLab