Lint ReformChanges component

src/lib/components/ReformsChanges.svelte

@@ -8,11 +8,11 @@
     getParameter,
     rootParameter,
   } from "$lib/parameters"
-  import type { ParametricReform } from "$lib/reforms"
   import {
     ParameterReformChangeType,
     reformChangesByName,
-    reformMetadataByName,
+    // reformMetadataByName,
+    type ParametricReform,
   } from "$lib/reforms"
   import { newSimulationUrl } from "$lib/urls"
   import { formatValue } from "$lib/values"
@@ -25,29 +25,30 @@
 
   const billName = getContext("billName") as Writable<string | undefined>
 
-  $: billChanges = reformChangesByName[$billName]
+  $: billChanges =
+    $billName === undefined ? undefined : reformChangesByName[$billName]
 
-  function* walkParametersChangeName(parameterChange, ids: string[] = []) {
-    if (Object.keys(parameterChange).length === 1) {
-      for (const [parameterId, childChange] of Object.entries(
-        parameterChange,
-      )) {
-        if (
-          (childChange as { children: { [key: string]: unknown } }).children ===
-          undefined
-        ) {
-          yield [...ids, parameterId].join(".")
-        } else {
-          yield* walkParametersChangeName(
-            (childChange as { children: { [key: string]: unknown } }).children,
-            [...ids, parameterId],
-          )
-        }
-      }
-    } else {
-      yield ids.join(".")
-    }
-  }
+  // function* walkParametersChangeName(parameterChange, ids: string[] = []) {
+  //   if (Object.keys(parameterChange).length === 1) {
+  //     for (const [parameterId, childChange] of Object.entries(
+  //       parameterChange,
+  //     )) {
+  //       if (
+  //         (childChange as { children: { [key: string]: unknown } }).children ===
+  //         undefined
+  //       ) {
+  //         yield [...ids, parameterId].join(".")
+  //       } else {
+  //         yield* walkParametersChangeName(
+  //           (childChange as { children: { [key: string]: unknown } }).children,
+  //           [...ids, parameterId],
+  //         )
+  //       }
+  //     }
+  //   } else {
+  //     yield ids.join(".")
+  //   }
+  // }
 </script>
 
 <!--{#if $billName !== undefined}-->
@@ -185,7 +186,7 @@
               ...displayMode,
               parameterName,
               parametersVariableName: undefined,
-            })}>{parameter.titles.filter(Boolean).join(" > ")}&nbsp;=</a
+            })}>{parameter?.titles?.filter(Boolean).join(" > ")}&nbsp;=</a
           >
           <br />
           {#if parameterReform.type === ParameterReformChangeType.Scale}
@@ -194,7 +195,7 @@
             <span class="bg-le-jaune text-right font-bold"
               >{formatValue(
                 parameterReform.value,
-                asValueParameter(parameter).unit,
+                asValueParameter(parameter)?.unit,
               )}</span
             >
           {/if}